Skip to content

fix: tag releases before opening new pull requests#753

Merged
chingor13 merged 3 commits intomainfrom
tag-first
Apr 11, 2023
Merged

fix: tag releases before opening new pull requests#753
chingor13 merged 3 commits intomainfrom
tag-first

Conversation

@chingor13
Copy link
Copy Markdown
Contributor

Fixes #747

@chingor13 chingor13 requested a review from bcoe April 10, 2023 18:15
@chingor13 chingor13 enabled auto-merge (squash) April 11, 2023 15:51
@chingor13 chingor13 merged commit 6a803df into main Apr 11, 2023
@chingor13 chingor13 deleted the tag-first branch April 11, 2023 15:52
This was referenced Apr 11, 2023
cdata referenced this pull request in cdata/release-please-action May 9, 2023
@Nickersoft
Copy link
Copy Markdown

I believe this PR caused a regression. I've been trying to hunt down the cause of my issue for months, and originally posted about it here. I finally pinpointed it to this change, and was able to fix my deploys by locking the GH action version to v3.7.6. Effectively, all of my releases would fail with "Not Found".

@s33dunda
Copy link
Copy Markdown

I believe this PR caused a regression. I've been trying to hunt down the cause of my issue for months, and originally posted about it here. I finally pinpointed it to this change, and was able to fix my deploys by locking the GH action version to v3.7.6. Effectively, all of my releases would fail with "Not Found".

@Nickersoft i'm having this issue as well. I've tried granting all permissions to my PAT to no avail. The release-please does it's job; we just have this false-negatives. sigh Did you ever find a fix beyond pinning an older version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

manifest command takes a while when the release PR is merged

4 participants